Skip to content

Conversation

briangesteban
Copy link
Member

Web Dev Path
238

Have you updated the CHANGELOG.md file? If not, please do it.

Other devs already did.

What is this change?

Update: Merge the current main(prod) to refactor/styles-migration.

Were there any complications while making this change?

None.

When should this be merged?

Can be merge to refactor/styles-migration as soon as we are able.

Copy link

netlify bot commented Jul 1, 2025

Deploy Preview for webdevpathstage ready!

Name Link
🔨 Latest commit e47c876
🔍 Latest deploy log https://app.netlify.com/projects/webdevpathstage/deploys/686357a9c4b2b70008da79e2
😎 Deploy Preview https://deploy-preview-244--webdevpathstage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@Satoshi-Sh Satoshi-Sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this merge, we might want to set the rule for the refactor/styles-migration like needing 2 approvals to merge?

@cherylli
Copy link
Member

cherylli commented Jul 3, 2025

After this merge, we might want to set the rule for the refactor/styles-migration like needing 2 approvals to merge?

one might be ok, since we'll have to review again when merging back to main

Copy link
Member

@cherylli cherylli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Satoshi-Sh
Copy link
Member

Satoshi-Sh commented Jul 3, 2025

one might be ok, since we'll have to review again when merging back to main

I feel it's better to have two reviews on small portions, as a merge to main will be huge.

@briangesteban
Copy link
Member Author

Maybe we could do:
1 Approval - Just for updating refactor/styles-migration from current main.
2 Approvals - If its a new feature-branch to be merged in to refactor/styles-migration.
3 Approvals - If refactor/styles-migration is done and will be merged to main.

@briangesteban briangesteban merged commit 2fcbb79 into refactor/styles-migration Jul 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants